Moinak Ghosh wrote: > On Mon, Jun 23, 2008 at 11:53 PM, Karen Tung <Karen.Tung at sun.com> wrote: > >> Hi, >> >> Please review my changes for bug 2263: microroot overflows with latest >> changes to IPS >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=2263 >> >> webrev is at: >> >> http://cr.opensolaris.org/~ktung/2263_fix/ >> > > Need an rm in lines 61-63: > > 61 if [ $? -ne 0 ] ; then > 62 echo "Failed to turn on IPS download cache purging" > >>> rm -f $tmp_cfg >>> > 63 return $status > > Otherwise the function can return leaving a temp file. Otherwise looks > fine to me. > > Regards, > Moinak. > > Hi Moinak,
Thanks for the code review. I will add the rm call as suggested. Thanks, --Karen
