[caiman-discuss] Code review request for bug 1258

[Jedy Wang]

The patch looks fine to me.

Regards,

Jedy
On Mon, 2008-06-30 at 02:52 -0700, Niall Power wrote:
> Hi,
> 
> This is for bug 1258 - Locale screen: Change "Locale:" dropdown label
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1258
> 
> Despite the webrev, this is a trivial change, just changing the label from
> "Locale:" to "Territory:". The bulk of the diff is because glade files are 
> autogenerated and therfore diffs can be large even for small changes.
> The changes in the glade file specific to this fix are:
> 
> -            <property name="yalign">0</property>
> -            <property name="label" translatable="yes">&lt;span 
> font_desc="Bold"&gt;_Language:&lt;/span&gt;</property>
> +            <property name="xalign">1</property>
> +            <property name="label" translatable="yes">&lt;span 
> font_desc="Bold"&gt;_Territory:&lt;/span&gt;</property>
>              <property name="use_markup">True</property>
> 
> I've also fixed a minor alignement issue. The two labels now align up
> against the edge of the list and combo boxes respectively which gives
> the proper horizontal alignment.
> 
> Full webrev at:
> http://cr.opensolaris.org/~niall/bug-1258
> 
> Thanks,
> Niall
> --
> This message posted from opensolaris.org
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss