Hi Ethan and team, Here are my comments:
Section 1.3: - Shouldn't there be a dependency on the parser to allow data from the manifest to be modifiable? Section 2: - Will one derived manifest correspond to 1 derivation module? If I have code in 1 derivation module that can be re-used by 2 different derived manifests, would I have to register this same derivation module 2 times, each time with a different manifest? Section 3.3: - Perhaps it is implied, but I think it would be more clear to explicitly say whether the associated module with the derivation functions is automatically deleted or not when you delete a derived manifest. Section 5.2, second paragraph, "The installadm add subcommand....." - Just curious, how would the server env be able to determine whether the the given manifest and the derivation module will derive a valid manifest, before the values are actually derived. From the server side, I think we can validate that all fields that require values either have values or have functions to derive a value. We can also validate that the function they specify indeed exist in the derivation module. Until we have the context of the client, I don't think you can really execute any code.. Section 5.3 - Will this new smf service for deriving the XML file end when it has completed it's work? Will it output a "new" manifest with the derived values to be consumed by the auto-install smf service? Before it create this "new" manifest, will it also validated the manifest syntactically, semantically...etc.. So, the auto-install smf service can assume that the given manifest is valid and not need to do duplicate work? - Also, since this smf service is separate from the the auto-install smf service, how would the output/error from this service be reported? Will it be a separate log file from the auto-install service? Section 6: - All the uses cases are not really use cases. To me, they are more like pseudo-code describing the code path of different things that can happen when derived manifests are used. Thanks, --Karen Ethan Quach wrote: > > The functional spec for AI derived manifests is posted at: > > http://www.opensolaris.org/os/project/caiman/auto_install/DerivedManifests/AI_derived_manifests_func_spec.txt > > > > > I would appreciate and feedback comments. > > > thanks, > -ethan > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
