Hi Jan, The code changes look fine to me and thanks for adding the great comment on why the extra blank line is needed here. That definitely makes this more readable. :-)
I also saw Jack's comment on the use of "CLI cmd:" and wondered about that as well. I agree with him that something for example like "exec command:" or "command run:" might be more understandable for this prefix. Thanks, -evan Jan Damborsky wrote: > Hi Karen, > > could I please ask you to review easy fix > for following bug ? > > 12853 'pkg cmd:' prefix emitted by > install_utils.exec_cmd_outputs_to_log() is confusing in DC log > > Please ignore following message in log files generated by pkg(1) > (I verified the issue has been addressed in latest pkg): > ... > /usr/lib/python2.6/vendor-packages/pkg/manifest.py:32: > DeprecationWarning: the sha module is deprecated; use the hashlib module > instead > import sha > ... > > Thank you very much, > Jan > > > * Webrev > http://cr.opensolaris.org/~dambi/bug-12853/ > > * Modules affected > - install_utils.py > > * Testing done > - DC build done with modified install_utils.py > - AI installation done with modified install_utils.py > > * DC & AI log files > http://cr.opensolaris.org/~dambi/bugs-12853-logs/ > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
