All, This is just a reminder that we'd like the first round of comments by COB December 11 (this Friday). We realize this is rather aggressive; remember that this is a preliminary review, and we will open up for a second round of comments upon completion of the remaining major components. Also remember that there's no need to personally review every file. Please feel free to take a small, manageable set of files!
This first review focuses on the UI: our preference for comments is on any files under usr/src/cmd/text-install/osol_install/text_install (though we welcome any comments). Note that those files break down into two main categories: "Screens" (files containing classes that are subclasses of 'BaseScreen') and "UI components" (everything else). "Screens" represent the Text Installer specific screens, whereas the UI components are more generic (and will be moved to a separate directory for the second round of code review, to present better structure). Please note that the file usr/src/cmd/text-install/osol_install/profile/disk_info.py has changed significantly since the webrev. (You can see some of the updates in the project gate, if interested). As such, it may not be as valuable to review that file. Finally, there will be another code walkthrough tomorrow (Dec 8), as a follow-up to last week's walkthrough. Again, please contact me directly to coordinate conference call details. This walkthrough will dive into more detail on the following, as time allows: class: DiskInfo class: DiskWindow screen: Users Thank you, Keith Sue Sohn wrote: > The Text Install project is requesting a code review of all code done > thus far. > > The webrev is located at: > > http://cr.opensolaris.org/~kemitche/text_v1 > > We are holding a preliminary code review because the UI is mostly > complete and > there is quite a lot of code to be reviewed. Although there will be > another code > review later in the project, this will give people more time to review > the code > and provide comments. Feel free to review all the files or a subset. > > Please send review comments by COB December 11, 2009. > > Keith will be holding a code walkthrough of the UI on Tuesday, December > 1 (time > TBD). Interested parties should contact keith.mitchell at sun.com to ensure > proper > coordination of the conference call details. > > Thanks, > Sue >
