On Thu, 10 Dec 2009, Joseph J VLcek wrote: > Alok Aggarwal wrote: >> Could I please get a couple of people to review the >> following bugs? >> >> 13213 DC AI/LiveCD x86 build fails in grub_setup.py: "NameError: name >> 'release' >> is not defined" >> 13215 x86 AI/LiveCD booted from media fails in GRUB - boot archive not >> found >> >> Webrev is at: >> >> http://cr.opensolaris.org/~aalok/13213-13215/ >> >> The following testing will be done before pushing: >> >> a) Build an x86 AI image, verify the build succeeds. >> Verify all the GRUB options on the media work. >> >> b) Build a LiveCD image, verify the build succeeds. >> Verify all the GRUB options on the media work. >> >> Thanks, >> Alok >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > Alok, > > > I was concerned this might not be correct for 32 bit where $ISADIR would be > empty resulting in /platform/i86pc//boot_archive > > Alok and I tested it by manually editing the GRUB entry to create this test > situation and it did work with the "//" in the path. > > Thanks for humoring me Alok!
Thanks for the review, Joe. Alok
