Jeffrey Huang wrote: > Hi, Jan, > > ? 2009/12/16 18:58, Jan Damborsky ??: >> In order to reflect comments received during code review, >> the implementation was slightly modified - the main changes >> can be summarized as following (Bug reports will be updated >> appropriately): > > Thanks your clear description of selection criteria. I've updated the > test cases list in the following, please have a review.
Hi Jeffrey, the test cases look good, I have only nits - please see below. Thank you very much, Jan > > BTW, for: > * multiple criteria from G2 can be specified at once > > Although I created test cases for that, but I remembered once before > I got answer from dev team that all 3 criteria must be matched at the > same > time. So has the rule changed? This behavior didn't change: * any combination of G2 criteria can be specified (1,2,3) * those specified have to be met Example of valid <ai_target_device> section: <ai_target_device> <target_device_vendor> HITACHI </target_device_vendor> <target_device_type> SCSI </target_device_type> </ai_target_device> Then target disk has to be 'SCSI' type _AND_ from Hitachi vendor. > > ASSERTION: target_02 > # DESCRIPTION: > # Verify only one target criterion can be specified in manifest -> # Verify only one target criterion from group 1 can be specified in manifest > # Define 2 target selection criteria at the same -> # Define 2 target selection criteria at the same time