Jack,

Yes.  That is correct.

John

Jack Schwartz wrote:
> Hi John.
> 
> Looks reasonable to me.  As I understand it, if the inner for loop 
> doesn't initialize sdict[name] with criteria, it is initialized to an 
> empty list.
> 
>    Thanks,
>    Jack
> 
> John Fischer wrote:
>> All,
>>
>> Here is a simple code review for installadm list subcommand.
>> The current code uses the else clause for a for loop.  The
>> name within the else clause is not defined within that context.
>> Removing the else causes the code to be in the main 'for name'
>> loop which has the 'name' defined within that context.
>>
>>     http://cr.opensolaris.org/~johnfisc/list-output-13550/
>>
>> This issue only shows up when a manifest has no criteria which
>> is why I missed it within the first code drop.
>>
>> Thanks,
>>
>> John
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
> 

Reply via email to