Joseph J VLcek wrote: > Jean McCormack wrote: >> Joseph J VLcek wrote: >>> Roland, and anyone else interested... >>> >>> Please review: >>> >>> http://cr.opensolaris.org/~joev/bug1462 >>> >>> >>> which addresses >>> >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1462 >>> >>> This change represents a fairly extensive re-write of usbgen. >>> >>> >>> Testing done: >>> >>> [1] Ran full Distro Constructor build >>> [2] Built usb images using OpenSolaris-2008-05_rc3.iso >>> [3] Because I added error handling I manually induced error into the >>> script to confirm the error handling. I then removed the errors. >>> [4] usbcopy-ed usb image to usb-stick, booted on test machine and >>> ran full Install. >>> >>> >>> Any and all input/suggestions most welcome. >>> >>> Thanks to Roland for the input he has already provided. >>> >>> Joe >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> Why did you add the #ident keywords? >> >> lines 70 & 72: genrated -> generated. >> Line 69 & 70: I don't think I agree with this. There very well might >> be a usb image of the same name sitting there >> from a previous build. I just want a new one created. That's the >> way the old usbgen functioned isn't it? >> >> We had talked about you rolling in my bug 1402 into your fix. So I'll >> address that now. >> I think lines 272, & 278 should have a call to error_handler. This >> would rm the dirs that have been created. > > Thanks Jean, > > I had gone back and forth on what do to if the USB image is already > there. I had figured letting the user know and remove it then restart > usbgen would be the safest thing... but I could go either way. I think it should do whatever the old version did. If we want to change the functionality of this, it should come under a separate bug. Does that sound reasonable? I think the old one just wrote over the top of a preexisting image. But you should check me on that.
Jean > > I'll address these issues as you describe. > > Joe > >> >> Jean
