Jack Schwartz wrote: > Hi Jean. > > It isn't clear to me from the bug report whether by "$DIST_IO_SORT is > empty" means the environment variable is not set, or whether the file > it points to is empty. It is clear that you interpreted this to be > the latter, but I don't think that's what was intended. But the > following leads me to believe he was referring to an unset environment > variable. > > With $junk undefined, > sh returns 1 from [ -f $junk ] > bash returns 0 > > With junk defined and pointing to an empty file, > both sh and bash return 0 when I do [ -f $junk ] > > Finally, the output of the mkisofs command in the bug report makes me > wonder if there is something missing from the commandline. It says: > mkisofs: No such file or directory. Can't open sort file list -quiet > That makes me think the commandline args are shifted due to a missing > arg, which could come from an undefined environment variable. > > So before saying it looks OK, I'd like to check with the bugfiler what > he meant. Looks to me like he was referring to an undefined > environment variable, not to an environment variable which points to > an empty file. Well whether he meant that or not, it should check for both. Change coming....
Jean > > Thanks, > Jack > > Jean McCormack wrote: >> Can Jack look at this, please? >> It's for bug 774: Distro constructor fails when DIST_ISO_SORT is empty >> >> Webrev: http://cr.opensolaris.org/~jeanm/distro_constructor/ >> >> Bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=774 >> >> Jean >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
