Dave Miner wrote: > Sundar Yamunachari wrote: >> Dave Miner wrote: >>> I'd like a review of the fix for >>> >>> 496 need to provide a workaround for sendmail's FQDN warning >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=496 >>> >>> There are changes in the GUI and orchestrator code which are >>> somewhat unrelated to the original bug, so persons familiar with >>> each would be appreciated as reviewers. >>> >>> Webrev is at >>> >>> http://cr.opensolaris.org/~dminer/slim_source/ >>> >>> Thanks >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> perform_slim_install.c: >> >> 26: Remove this line >> 141: The function set_entry() is not defined in this file. This line >> can be removed >> 1264, 1272, 1275: May have to free tmpnam >> > > Above all accepted. > >> There are lot of pfinstall references in this file and header files. >> We need to cleanup that too. >> > > Yeah, I started to look at that but decided it was a separate bug. > File it if you feel like it, otherwise I will next week. I Will file a bug. > >> orchestrator_private.h: >> >> 29, 291-293 : Remove these lines >> > > Accepted. Noticed a few others that needed removing while I was there. > >> installation-screen.c: >> >> 658: Change the comment from 81% to 94% >> 700: Change the comment from 76% to 89% >> > > Done. > > Webrev respun. Collapse of changesets will happen before putback. > > http://cr.opensolaris.org/~dminer/slim_source/ > > I'm gone 'til Monday so no hurry on the re-review. > > Dave Looks good now.
- Sundar
