Hi, Requesting code review for bug 768: Installer crashes if slideshow images aren't present on media http://defect.opensolaris.org/bz/show_bug.cgi?id=768
Webrev of changes is at: http://cr.opensolaris.org/~niall/bug-768/ Overview: The SEGV is caused when the the GUI attemps to dereference inside a NULL pointer without first checking it. A check has been added. If there are no slideshow image files then the GtkImage widget used to display the images is destroyed in order to free up the resources since it won't be used. The two timer/arrow-key event functions now short circuit if there are no slide show images. I've also removed the InstallationFileData structure definition and references to it. I've replaced it with a simple gchar *, since that was the only member of the structure. I've renamed the function display_progress_info() to dispaly_slideshow_image() to better reflect it's actual purpose, and ajusted it's 2nd parameter to expect a gchar * pointing to the image file path instead of a InstallationFileData type structure. In the glade file, I've set the GtkImage property for the slidehow image to be visible. Thanks, Niall. -- This message posted from opensolaris.org
