Jack Schwartz wrote: > Hi Jean. > > Here are my comments: > > build_dist.bash: > line 113: nit: adding a break would be a slight optimization. >
It will probably have minimal impact since df -k $DIST_PROTO will typically have just 2 lines of output. > build_dist.lib: > Not sure if the echos on lines 260 and 282 are just for debugging or are > intended to be part of the finished code. They both follow a less > detailed "Compressing filesystem image" message. > > pkgs.txt: > Knowing just enough to be dangerous, it would seem more logical to me > for the slim people to add p7zip to SUNWslim-utils since it is a > utility. This would seem a more solid fix. Do you know if there are > plans for this? ... or perhaps adding SUNWp7zip is just a temporary > workaround? > IMHO p7zip is a generally useful compression utility outside of Slim Install and a SUNWp7zip package is needed. Adding p7zip to SUNWslim-utils will make one file appear in two packages. Regards, Moinak. > Thanks, > Jack > > Jean McCormack wrote: > >> Moinak, Jan and Sanjay should look at this: >> >> The changes are here: >> >> http://cr.opensolaris.org/~jeanm/distro_constructor/ >> >> >> The changes address: >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=844 >> http://defect.opensolaris.org/bz/show_bug.cgi?id=845 >> http://defect.opensolaris.org/bz/show_bug.cgi?id=852 >> >> >> Jean >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
