Minor point: -> is a primary expression operator and is evaluated before binary operators, so parentheses are unnecessary. The fix looks fine. William Dave Miner wrote: > Please review > > http://cr.opensolaris.org/~dminer/slim_source/ > > Which addresses > > 413 Incorrect mode on zero-length files after installation > http://defect.opensolaris.org/bz/show_bug.cgi?id=413 > > Thanks, > Dave > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
- [caiman-discuss] Code review request Jean McCormack
- [caiman-discuss] Code review request Dave Miner
- [caiman-discuss] Code review request Jean McCormack
- [caiman-discuss] Code review request Dave Miner
- [caiman-discuss] Code review request Jean McCormack
- [caiman-discuss] Code review request Dave Miner
- [caiman-discuss] Code review request Glenn Lagasse
- [caiman-discuss] Code review request david.co...@sun.com
- [caiman-discuss] Code review request Dave Miner
- [caiman-discuss] Code review request Dave Miner
- [caiman-discuss] Code review request William Schumann
- [caiman-discuss] Code review request Dave Miner
- [caiman-discuss] Code review request Joseph J VLcek
- [caiman-discuss] Code review request Alok Aggarwal
- [caiman-discuss] Code review request John Levon
- [caiman-discuss] Code review request Alok Aggarwal
- [caiman-discuss] Code review request sanjay nadkarni (Laptop)
- [caiman-discuss] Code review request Clay Baenziger
- [caiman-discuss] Code review request Dave Miner
- [caiman-discuss] Code review request Karen Tung
- [caiman-discuss] Code review request Dave Miner