Hi Clay.
I'm OK with the items I've snipped; comments below on other items.
On 10/02/09 14:28, Clay Baenziger wrote:
>
>> 380, 397: /var/ai/image-server/images is in these two places at
>> least. Please define a common string somewhere for these. Better
>> yet, /var/ai is used in even more places. If the string
>> /var/ai/image-server/images would have to change if the /var/ai
>> string did, please define /var/ai somewhere and use in all places
>> the variable which carries that string.
>
> I agree, this is bug 4402 (Pull fixed strings in A/I server python
> code out to a separate module) as I'd like to look into some various
> solutions for this. I don't think I've yet found a clean way to do
> this as I'd like.
Well, OK, but the longer we wait to fix this kind of thing, the more
unmaintainable the code gets in the meantime...
>
>> 425: Does the microroot-less vfstab file get written somehow?
>
> The function on 418 updates the backing-store (the /etc/vfstab file):
> del(vfstabObj.fields.MOUNT_POINT[idx])
OK. I found this in installadm_common.py line 425, but is not obvious.
Please add a comment that this happens.
>> 685: I don't understand the comments here. I think "again" may be
>> causing confusion. Also, what SMF tests were run? Can 686/687 be a
>> separate comment from 685?
>
> Good point this was rather vague. How's this for clarification?
> # no identifying SMF properties were found, nor were SPARC files found,
> # so try looking for X86 files.
> # both X86 clients and services need equivalent files removed
> # from tftpboot (so, look for /tftpboot/<service or client name>)
This is still not clear to me. Not sure how the second part about X86
clients and services need equivalent files removed is relevant here. As
for the first part, is this accurate:
No SMF properties or files were found to identify this arch as SPARC, so
try looking for X86 files.
Thanks,
Jack
