On 10/12/09 12:16, Evan Layton wrote: > Keith Mitchell wrote: >> >> >> Evan Layton wrote: >>> In final testing over the weekend I found that I had a problem with >>> the fix. If the mountpoint for the pool being used was not the same >>> as the name of the pool then the ICT call would fail to create >>> menu.lst. The causes for this were due to two problems. First I was >>> passing the name of the pool to the add_splash_image_to_grub_menu >>> ICT. This should have been passing the mountpoint of the pool and >>> not the pool name. Secondly in the ICT it was always pulling the >>> name of the pool out of /etc/mnttab and using that as the mountpoint >>> for the pool when creating the menu.lst. This is normally OK for >>> an install, however when running on an installed system the pools' >>> mountpoint can be different than the name. >>> >>> I've made these changes and retested, the fix now passes this test >>> as well. >>> >>> The webrev with just these changes is at: >>> http://cr.opensolaris.org/~evanl/7880v3/ >> >> Minor nit: Line 383 - put the comment on a separate line, so you don't >> have to wrap the line at all. >> > > fixed and updated... > > Thanks! > -evan
Hi Evan, Same minor nit at 379. And should the comments be different for 383 and 379? In be_utils, might be good to modify/expand the comment at 384 (or somewhere) to include more information about why we're using the mount point rather than the name. Sue
