> Alexander Eremin wrote: > >> Alexander Eremin wrote: > >> > >>> On Wed, 2009-10-07 at 17:16 -0700, Karen Tung > >>> > >> wrote: > >> > >>> > >>> > >>>> line 109: should this os.access() check be done > >>>> > >> for the destination > >> > >>>> file, to > >>>> make sure that the cpio command really did > >>>> > >> succeed? > >> > >>>> > >>>> > >>> I'm not shure that this is required, cpio copies > >>> > >> all include symlinks, > >> > >>> after this we need to compress only files, and if > >>> > >> else some file will > >> > >>> not be copied, it will be putting in destination > >>> > >> directory by > >> > >>> fiocompress.. > >>> > >>> > >>> > >>> > >> Hi Alexander, > >> > >> I read the code again. The check in line 109 was > >> added by your change. > >> Why did you add the check? It actually seems > >> unnecessary. > >> > >> Thanks, > >> > >> --Karen > >> > >> > >> _______________________________________________ > >> caiman-discuss mailing list > >> caiman-discuss at opensolaris.org > >> > http://mail.opensolaris.org/mailman/listinfo/caiman-di > >> scuss > >> > > > > Oh, I misunderstood previous message, sorry. > > Agree, webrev's updated > > > > Cheers, > > Alex > > > Hi Alexander, > > Thanks for making the changes. I have no further > comments in your changes. > > --Karen > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss
Thanks Karen for taking the time to review, Regards, Alex -- This message posted from opensolaris.org
