Hi Jan, The changes look fine to me.
Sue On 10/15/09 04:24, Jan Damborsky wrote: > Hi, > > could I please ask for reviewing the simple fix for following bug ? > > 11958 namespace collision with dump_nvlist in slim_source as of build 125 > > * Webrev: > http://cr.opensolaris.org/~dambi/bug-11958 > > Thank you, > Jan > > > > Modules affected and tested: > * tdmgtst - Target Discovery test driver > > tests carried out: > * full build succeeded on both x86 and Sparc - tested builds: > - build 122 (w/o fix for 6882947) > - build 125 (w/ fix for 6882947) > > regression test > * verified that tdmgtst driver produced same results > with and without the fix > > # tdmgtst -d > Caiman Target Discovery test program - Version 4 > disk discovery: > 2 found - getting attributes... > disk 0) > ddm_disk_size=488390624 (uint64) > ddm_disk_block_size=512 (uint32) > ddm_disk_mtype=1 (uint32) > ddm_disk_nheads=16 (uint32) > ddm_disk_nsectors=465 (uint32) > ddm_disk_name=c3t1d0 > ddm_disk_currboot=yes > ddm_disk_vendor_id=HITACHI > ddm_disk_product_id=HDS7225SCSUN250G 0719BMNJSK > ddm_disk_dev_id=/dev/rdsk/c3t1d0s0 > ddm_disk_ctype=scsi > ddm_disk_label=1 (uint32) > disk 1) > ddm_disk_size=488390624 (uint64) > ddm_disk_block_size=512 (uint32) > ddm_disk_mtype=1 (uint32) > ddm_disk_nheads=16 (uint32) > ddm_disk_nsectors=465 (uint32) > ddm_disk_name=c3t0d0 > ddm_disk_vendor_id=HITACHI > ddm_disk_product_id=HDS7225SCSUN250G 0719BMWJDK > ddm_disk_dev_id=/dev/rdsk/c3t0d0s0 > ddm_disk_ctype=scsi > ddm_disk_label=1 (uint32) > partition discovery: > 0 found - getting attributes... > slice discovery: > 10 found - getting attributes... > slice 0) > ddm_slice_index=2 (uint32) > ddm_slice_start=0 (uint64) > ddm_slice_size=487565520 (uint64) > ddm_slice_tag=5 (uint32) > ddm_slice_flag=1 (uint32) > ddm_slice_devt=8388626 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d707a9/c > ddm_slice_name=c3t1d0s2 > ddm_slice_lastmnt= > slice 1) > ddm_slice_index=1 (uint32) > ddm_slice_start=0 (uint64) > ddm_slice_size=4196160 (uint64) > ddm_slice_tag=3 (uint32) > ddm_slice_flag=1 (uint32) > ddm_slice_devt=8388625 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d707a9/b > ddm_slice_name=c3t1d0s1 > ddm_slice_lastmnt= > slice 2) > ddm_slice_index=0 (uint32) > ddm_slice_start=4196160 (uint64) > ddm_slice_size=483369360 (uint64) > ddm_slice_tag=2 (uint32) > ddm_slice_flag=0 (uint32) > ddm_slice_devt=8388624 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d707a9/a > ddm_slice_name=c3t1d0s0 > ddm_slice_lastmnt= > slice 3) > ddm_slice_index=7 (uint32) > ddm_slice_start=110796480 (uint64) > ddm_slice_size=376769040 (uint64) > ddm_slice_tag=8 (uint32) > ddm_slice_flag=0 (uint32) > ddm_slice_devt=8388623 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d721e5/h > ddm_slice_name=c3t0d0s7 > ddm_slice_lastmnt= > slice 4) > ddm_slice_index=3 (uint32) > ddm_slice_start=8392320 (uint64) > ddm_slice_size=51202080 (uint64) > ddm_slice_tag=2 (uint32) > ddm_slice_flag=0 (uint32) > ddm_slice_devt=8388619 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d721e5/d > ddm_slice_name=c3t0d0s3 > ddm_slice_lastmnt=/ > slice 5) > ddm_slice_index=2 (uint32) > ddm_slice_start=0 (uint64) > ddm_slice_size=487565520 (uint64) > ddm_slice_tag=5 (uint32) > ddm_slice_flag=0 (uint32) > ddm_slice_devt=8388618 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d721e5/c > ddm_slice_name=c3t0d0s2 > ddm_slice_lastmnt= > slice 6) > ddm_slice_index=1 (uint32) > ddm_slice_start=0 (uint64) > ddm_slice_size=8392320 (uint64) > ddm_slice_tag=3 (uint32) > ddm_slice_flag=1 (uint32) > ddm_slice_devt=8388617 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d721e5/b > ddm_slice_name=c3t0d0s1 > ddm_slice_lastmnt= > slice 7) > ddm_slice_index=0 (uint32) > ddm_slice_start=59594400 (uint64) > ddm_slice_size=51202080 (uint64) > ddm_slice_tag=0 (uint32) > ddm_slice_flag=0 (uint32) > ddm_slice_devt=8388616 (uint64) > ddm_slice_devid=id1,sd at n5000cca210d721e5/a > ddm_slice_name=c3t0d0s0 > ddm_slice_lastmnt= > slice 8) > [empty nvlist] > slice 9) > [empty nvlist] > found swap device /dev/zvol/dsk/rpool/swap > Solaris instance discovery: > 2 found - getting attributes... > Solaris instance 0) > os_version=Solaris_11 > os_slice_name=c3t0d0s3 > os_build_id=snv_102 > Solaris instance 1) > os_build_id=Pool member > os_slice_name=c3t0d0s7 > releasing resources... > finished. > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
