Matt Keenan wrote:
> Evan Layton wrote:
>> Hi Matt,
>>
>> Since these changes expose the problem described in bug 12204 and
>> that bug is a regression shouldn't the fix for that bug get pushed at
>> the same time as this fix for 1436? It seems like this fix would
>> cause the regression to at least show up when pushed.
>
> No idea if this is a regression or not, but definitely exists now. In
> most
> cases people would have always provided and therefore not experiencing
> this issue. But with my changes, everyone would experience this issue.
>
> Agree that 12204 should get resolved ASAP, and I would be happy to
> push it as
> part of this fix. (I don't have a resolution though).
>
>> Also if these changes are pushed and we still have "" set as the root
>> password does this affect the ability to login to single user mode?
>> That is without having to set the password as you mentioned in your
>> testing?
>
> Absolutely, you cannot login as root at all until you manaully set the
> password
> to your preferences ("" or otherwise).
>
> I guess I need to try and figure out how to fix this in
> liborchestrator... any ideas ?
I agree with Evan that the fix for 1436 should not be pushed knowing
that it will cause issues. I am looking at the liborchestrator and I
will get back to you with some ideas.
- Sundar
>
> Matt
>
>> Thanks!
>> -evan
>>
>> Matt Keenan wrote:
>>>
>>> Thanks for the comments Sundar.
>>>
>>> I've logged bug :
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=12204
>>>
>>> to get liborchestrator fixed, based on this can I assume the changes
>>> here are ok
>>> to push back ?
>>>
>>> cheers
>>>
>>> Matt
>>>
>>> Sundar Yamunachari wrote:
>>>> Matt Keenan wrote:
>>>>> On test install entry in /etc/shadow for root is :
>>>>>
>>>>> root::14537::::::
>>>>>
>>>>> Which indicates it is set to "", yet
>>>>>
>>>>> $ su -
>>>>>
>>>>> fails as it prompts for a password, and simply pressing return
>>>>> fails to su.
>>>>>
>>>>> So I :
>>>>> $ pfexec passwd root
>>>>>
>>>>> And hit return twice, which should be setting root password to
>>>>> nothing.
>>>>> Now "su -" works when I just hit return for password, also now
>>>>> /etc/shadow
>>>>> now contains a hashed password for root.
>>>>>
>>>>> Is this behaviour expected, and acceptable ?
>>>> I think that it is a regression and the problem may be with the
>>>> orchestrator. It sets the password to "" if it is not passed. We
>>>> need to get it fixed.
>>>>
>>>> - Sundar
>>>>>
>>>>> cheers
>>>>>
>>>>> Matt
>>>>>
>>>>> Sundar Yamunachari wrote:
>>>>>> Matt,
>>>>>>
>>>>>> The changes look ok. The install library liborchestrator
>>>>>> expects root password and I think it sets the root password to
>>>>>> "", if it is not passed from the GUI. What is the root password
>>>>>> after your test installation with the fix?
>>>>>>
>>>>>> - Sundar
>>>>>>
>>>>>> Matt Keenan wrote:
>>>>>>>
>>>>>>> Are people ok with these changes going into the GUI ?
>>>>>>> Anyone get a chance to review ?
>>>>>>>
>>>>>>> cheers
>>>>>>>
>>>>>>> Matt
>>>>>>>
>>>>>>> Matt Keenan wrote:
>>>>>>>> Code review request for bug :
>>>>>>>> 1436 - Installation does not need to ask Root Password
>>>>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1436
>>>>>>>>
>>>>>>>> This fix also resolves bug :
>>>>>>>> 64 - GDM dosen't accept empty passwords, but setup does.
>>>>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=64
>>>>>>>>
>>>>>>>> Webrev :
>>>>>>>> http://cr.opensolaris.org/~mattman/bug_1436/
>>>>>>>>
>>>>>>>>
>>>>>>>> The users screen has been redesigned in that root password
>>>>>>>> entry fields have now been removed as they are not required.
>>>>>>>> However the change also makes log-in name
>>>>>>>> and password mandatory, this will ensure that for every install
>>>>>>>> a initial user
>>>>>>>> will be created with a password.
>>>>>>>>
>>>>>>>> Testing :
>>>>>>>> Created a install LiveCD ISO via Distro Constructor and did a
>>>>>>>> test install
>>>>>>>> within virtualbox.
>>>>>>>>
>>>>>>>> cheers
>>>>>>>>
>>>>>>>> Matt
>>>>>>>> _______________________________________________
>>>>>>>> caiman-discuss mailing list
>>>>>>>> caiman-discuss at opensolaris.org
>>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> caiman-discuss mailing list
>>>>>>> caiman-discuss at opensolaris.org
>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>>>
>>>>>
>>>>
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>
