Hi Jan - I agree. It could be misleading. I'll make the change. Thanks for the feedback.
Ginnie On 10/28/09 02:20, Jan Damborsky wrote: > Hi Ginnie, > > thank you for making these changes. > The update webrev looks good, I have only one nit > (no need for another code review round): > > 165, 204, 396 - comment says: > /* convert part. name (e.g. c0d0p0) */ > > It might be misleading, since 'p0' is not in valid range. > I might recommend to change it to something else - e.g. c0d0p1. > > Thank you, > Jan > > > Virginia Wray wrote: >> Hi - >> >> I've updated the extended partition work for the libdiskmgt work >> to include the code review feedback, as well as the associated CRs. >> >> CRs: >> 6895679 libdiskmgt needs to support extended partitions >> 6483812 libdiskmgt.so provides wrong values for the partition sizes >> >> Webrev: >> http://cr.opensolaris.org/~ginnie/libdisk4/ >> >> Thanks to everyone who provided feedback. >> > -- Ginnie
