Hi everyone.
Joe and I talked offline about this, and I am OK with his changes.
This boils down to a style issue which needs to be discussed and
standardized. There are some delivered scripts which set PATH and some
which use full pathnames for each command. There are "experts" backing
each way.
I will be posting a more-detailed email to caiman discuss about this
soon, to stimulate discussion and hopefully achieve resolution on a
"standard", at least for Install tools but maybe for an even wider
developer base.
Thanks,
Jack
On 10/26/09 09:24, Jack Schwartz wrote:
> Hi Joe.
>
> Thanks for your quick reply. There's one place which I want to
> clarify...
>
>>> create_vm:
>>>
>>> I second Karen's suggestion to use a full path to commands. This
>>> makes what is being run explicit and handles the case where the
>>> $PATH isn't set properly. Other distro-constructor scripts also do
>>> this.
>>
>> I tend to use full paths to commands but setting PATH is a good idea
>> in case a command is missed. Doing so was initially suggested to me
>> by Roland Mainz (Mr. bash) when I was working on usbgen. It is in our
>> ksh93 tips
>> http://installzone-wiki.central.sun.com/wiki/index.php/Ksh93_Tips
>>
>> I will be improve the comments around setting PATH.
> Actually, I was thinking of replacing things like:
>
> VBoxManage <args>....
>
> with
>
> # definitions near the top of the file
> VBOXMANAGE=/opt/VirtualBox/VBoxManage
>
> ...
> $VBOXMANAGE <args>....
>
> to neatly provide the full path to each command, and not rely on $PATH
> being set.
>
> Thanks,
> Jack
>
>
