jeanm wrote:
>>
>> - DefaultsModule.py, line 94:
>> this function name starts with an "_". It's kinda odd.
>> I know "__" is for private functions for a class. Not sure whether
>> "_" means anything. Do you think it might be OK to change it so
>> we don't have the "_"?
> The second _ was removed by mistake. I'll put it back to __ since it
> is private.
>
> Thanks for the review.
For future reference, from PEP-8:
Method Names and Instance Variables
...
Use one leading underscore only for non-public methods and instance
variables.
To avoid name clashes with subclasses, use two leading underscores to
invoke Python's name mangling rules.
>
> Jean
>>
>> Thanks,
>>
>> --Karen
>>
>> jeanm wrote:
>>> Here's the code review for my Python2.4->2.6 and pylint changes for DC.
>>>
>>> http://cr.opensolaris.org/~jeanm/slim_2.6/
>>>
>>> Can I ask Karen to look at this, along with anyone else who wants
>>> to, since she's familiar with the DC.
>>>
>>> Jean
>>>
>>>
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
