Hi Keith, be_create.c: ============= line 526 zret should probably be just ret and line 531 can probably be removed.
line 591 zret should be initialized to 0 (or BE_SUCESS since it's used for both zfs_iter function return codes and be_clone_fs_callback). It might be best as part of this to clean up these return variables so we make the use of things like err, zret and ret consistent. This needs to be looked at throughout... Maybe something like: err for capturing errno's zret for capturing zfs related errors ret for returning BE errors and errors that have been translated into BE errors. 1796 ret is defined here and again at line 1886. The second one isn't needed and should be removed. 2148 - 2150 returns err but doesn't set it so we could be sending an error from somewhere else or just what was initialized. This needs an actual error message. be_mount.c: =========== lines 238 and 395 ret should also be set to BE_SUCCESS 1441 set err = BE_SUCCESS? Other than these I don't see anything that hasn't already been mentioned. -evan Keith Mitchell wrote: > Hello, > > I'd like a CR for my fix for 3837. See webrev below. > > Note that I have not yet run tests, but, due to the nature of the > changes, I think it's unlikely tests these changes will cause problems. > I *will* run tests soon, and if for some reason something fails, will > fix and re-post. > > http://cr.opensolaris.org/~kemitche/3837/ > > Thanks, > Keith > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
