Hi Dave, Thanks for the feedback. My responses below.
* Dave Miner (dminer at opensolaris.org) wrote: > Glenn Lagasse wrote: > >All, > > > >I've posted the first rev of the design document for the Virtual Machine > >Constructor project at the following location: > > > ><http://www.opensolaris.org/os/project/caiman/VMC> > > > >Please provide any comments you may have by COB Friday, July 31st. If > >you need more time to review the document, please let me know. > > > >Thanks, > > > > General: section numbering would be helpful in providing review references. Good point. Sorry about that. I'll add that in. > VMC DC Manifest: Please consider making these new tags arguments to > the finalizer scripts instead. The DC manifest language seems > somewhat too application-specific when viewed in the context of the > unified engine work, and I'd like to see a moratorium on additional > tags until that's been sorted out some. If that's not practical for > some reason, consider at least introducing a new section specific to > this application of DC to group these tags within so that the > clutter is somewhat confined. Good idea. I'm pretty sure we can. My only concern is making sure the user can find them since they will have to have valid values that we can't know by default (location of AI media for instance). To me, the XML tags make it easy (they stand out). They are also the tag name and the value which helps understand what it is you're setting. But I think sufficient comments in the manifest near the arguments should suffice. > Finalizer scripts: Please add notes on why ksh is chosen for these > vs. other possible choices (at least python). Well, I see later on > that you have notes about this in the phasing, but I'd expect it > here where the decision is noted, or at least a reference. Good point, I'll move this up. > Phasing: Since it appears that the bootable AI image work will be > integrated well before your anticipated integration, does it really > make sense to deliver phase 1 as specified here? No it doesn't. What's in Phase 1 and Phase II will be delivered together (so we're going to combine them). Phase III will be post initial putback work. Thanks Dave! -- Glenn
