Clay,
Clay Baenziger wrote:
> Hi William,
> I think this looks good. I would say perhaps "size_units_data" or
> "data_size_units" might be good instead of "size_units", just for
> clarity and in case we find something else we eventually measure. I
> think that's just a nit or food for thought though.
I think that, since units here pertain to sizable amounts of space on
disk drives, disk_space_size_units might indicate the purpose of the
range of units clearly.
> Similarly, it just occurred to me the ambiguity of calling sectors
> SEC, or SECS with the possible crossing of meanings with seconds. Of
> course, in context, data sizes and time lengths should be
> differentiable but want to warn about that.
I decided that these ambiguities are less important than ease of use, so
I allowed a wide range of different unit names. Added comments
indicating that disk sectors are referred to here.
William
> Thank you,
> Clay
>
> On Tue, 13 Jan 2009, William Schumann wrote:
>
>> Clay,
>> I've added the code to support user-selectable slice units. It is very
>> similar to the partition code.
>> Would you please review the slice code?
>> Thank you,
>> William
>>
>> clayb at sun.com wrote:
>>> Hi William,
>>> Yes, that's what I was thinking.
>>>
>>> Thank you,
>>> Clay
>>>
>>> -----Original Message-----
>>>
>>> From: William Schumann <William.Schumann at Sun.COM>
>>> Subj: Re: [caiman-discuss] code review request 4460
>>> "partition_size" tag in ai_manifest.xml template should mention sectors
>>> Date: Tue Jan 13, 2009 8:36 am
>>> Size: 1K
>>> To: Clay Baenziger <clayb at sun.com>
>>> cc: caiman-discuss <caiman-discuss at opensolaris.org>
>>>
>>> Clay,
>>> Is this approach to abstracting disk units what you were suggesting?
>>> http://cr.opensolaris.org/~wmsch/bug-4460/usr/src/cmd/auto-install/ai_manifest.rng.udiff.html
>>>
>>>
>>> William
>>>
>>> Clay Baenziger wrote:
>>>
>>>> Hi William,
>>>> I like your changes, they look good. As per our IRC conversation:
>>>> In the schema file please abstract out disk units so other tags
>>>> can use them if we deem necessary.
>>>>
>>>> Also, in the schema, the XML 1.0 comment at the head looks fine,
>>>> for example, according to:
>>>> http://www.relaxng.org/spec-20011203.html#simple-syntax-example
>>>>
>>>> Otherwise, I didn't see any problems in the C code, it all looked
>>>> nice.
>>>> Thank you,
>>>> Clay
>>>>
>>>> On Mon, 1 Dec 2008, William Schumann wrote:
>>>>
>>>>
>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4460
>>>>> http://cr.opensolaris.org/~wmsch/bug-4460/
>>>>>
>>>>> Added ability to specify partition size units of either sectors or
>>>>> megabytes.
>>>>> Created new Relax NG element: partition_size_units, defaulting to
>>>>> megabytes
>>>>> _______________________________________________
>>>>> caiman-discuss mailing list
>>>>> caiman-discuss at opensolaris.org
>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>>
>>>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>>> --- message truncated ---
>>>
>>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
