jan damborsky wrote:
> Dave Miner wrote:
>> jan damborsky wrote:
>>> Hi Dave,
>>>
>>> looking at the changes, I can see that install-lan&keyboard-layout
>>> are removed from appropriate packages, but they will remain
>>> in slim_source gate.
>>>
>>> I think since they are no longer in use, we could remove also
>>> appropriate source codes from the gate - however, in that case
>>> usr/src/gui-install/src/Makefile would need to be accommodated
>>> as well.
>>>
>>> I am not sure if those changes might fall into the bug you
>>> are fixing - if you think they are out of the scope of this fix,
>>> could you please file separate bug for removing install-lan
>>> and keyboard-layout from slim_source gate ?
>>>
>>
>> Thanks for reviewing thoroughly, as you note that webrev wasn't 
>> complete.  I've pushed the right one, if you'd please re-review ;-)
> 
> Those changes I had in my mind :-)
> 
> I have only nit:
> usr/src/cmd/gui-install/Makefile
> --------------------------------
> It seems that only Copyright date was changed
> in that file. If this is the case, I think we
> might leave it unchanged.
> 

Also noted by Sanjay, will be reverted.

Thanks!
Dave



Reply via email to