The webrev has been updated. Only change is to transfer_mod.py. I retested the normal usage and then tested the error cases.
Jean Jean McCormack wrote: > Karen Tung wrote: > >> Hi Jean, >> >> One comment: >> >> For "TM_IPS_SET_PROP" mode in the transfer module, the prop name and >> prop value must be specified as a pair. Since there's no check to >> prevent people from >> specifying the prop name and/or value more than once, we might run >> into inconsistencies, if >> people are not calling the function correctly. If they do something >> like the following, >> it is "legal" according to the code, but it will mess them up: >> >> tm_perform_transfer([(TM_ATTR_MECHANISM, TM_PERFORM_IPS), >> (TM_IPS_ACTION, TM_IPS_SET_PROP), >> (TM_IPS_PROP_NAME, "flush-content-cache-on-success"), >> (TM_IPS_PROP_VALUE, "True"), >> (TM_IPS_PROP_NAME, "display-copyrights"), >> (TM_IPS_INIT_MNTPT, mntpt), >> (TM_PYTHON_LOG_HANDLER, dc_log)])) >> >> So, perhaps we should have some checks in the code to prevent the above? >> > Sure I can do that. Leads me to wonder if the rest of the transfer > module calls are quite that robust. > > Jean > > >> Thanks, >> >> --Karen >> >> >> >> >> Jean McCormack wrote: >> >>> Webrev: http://cr.opensolaris.org/~jeanm/slim_6102/ >>> >>> CR: http://defect.opensolaris.org/bz/show_bug.cgi?id=6102 >>> >>> Note: The changes to ict are consistent with the other code in the >>> module. I have >>> filed bug 6216 to look into changing ict to use the transfer module >>> for ips functionality. >>> I talked with both Karen and Joe about this issue. >>> >>> Jean >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
