Joe, I fixed the inconsistent use of spaces after #comments. Roland, I updated the webrev for your review. William
Joseph J VLcek wrote: > William Schumann wrote: > >> Joe, >> I added some comments to try to explain. Please let me know if it is >> understandable. >> I also moved the code to within 80 columns. >> Resubmitted webrev. >> Thanks, >> William >> Joseph J VLcek wrote: >> >>> William Schumann wrote: >>> >>>> http://cr.opensolaris.org/~wmsch/bug-1559/ >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1559 >>>> >>>> bootadm update-menu is run in an ICT to create the grub menu for the >>>> target >>>> disk. It invokes /sbin/biosdev, which determines the BIOS order of >>>> devices, >>>> which mkmenu uses. When the USB drive is booted, this order is >>>> temporarily >>>> disrupted, displacing all other disk numbers by 1 in that order, so >>>> it no >>>> longer matches the normal order when the USB drive is removed and the >>>> computer >>>> is rebooted. >>>> >>>> Fix: mkmenu determines this by checking for the presence of /.liveusb >>>> and then decrementing the number for all Windows disks >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>> William, >>> >>> This looks OK but I think a comment describing why $id >>> 7|11|12|18|23|222 are the special case might be helpful. >>> >>> Joe >>> > > Thanks William. > > Total nit... > > Comments on lines 222 & 223 lack the black space after the #, which > seems to be the norm in this file. > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
