jan damborsky wrote: > Hi Li Fan, > > my apologies for the delay. > > After taking a look at the orchestrator test drivers, > it is obvious they haven't been updated for a while > and some parts are currently out of sync with the set > of features implemented in orchestrator. This is also > the reason why building of keyboard test driver fails. > > We were discussing with Michelle and Eric some time > ago about how we might approach keeping test drivers > in sync with the latest set of features and we came to > the conclusion that QE team might participate > in this and we thought that the orchestrator might be > the good starting point. Since I agree this would take some > time to come up to speed on this stuff, I was offering help > and information necessary to make this process as seamless > and easy as possible. > > As situation might change since we were discussing > this last time, we might need to recheck with Eric and Michelle, > if this is how we will be approaching this goal or if different > approach would be more appropriate. > > Michelle, Eric, could I please ask you if you might > help us to clarify if this is still desired approach to follow ? >
My preference would be that the development team keep the basic test drivers up to date, in sync with the changes to the underlying functionality. This will help ensure the quality of the changes, and should be one thing that's consistently requested by reviewers of changes in those areas. One way to help get this going immediately would be to add the test driver targets, where they exist, to the standard "all" build targets. Dave > Thank you, > Jan > > > > Li Fan wrote: >> Hi Jan: >> >> When I tried to build liborchestrator test driver I can build disk >> test driver, but failed in building keyboard test driver. >> >> -bash-3.2# pwd /export/slim_source/usr/src/lib/liborchestrator >> >> -bash-3.2# export >> LD_LIBRARY_PATH=/export/slim_source//proto/root_i386/usr/snadm/lib:/export/slim_source/proto/root_i386/usr/lib:/lib:/usr/snadm/lib >> >> >> >> -bash-3.2# make disktest >> /opt/SUNWspro/bin/cc -xc99=%none -Xa -I/usr/include -I/usr/include >> -I. -I/usr/include/admin -I../libtd/ -I../liblogsvc -I../libti >> -Di386 -I/usr/include -I/usr/include -I. -I/usr/include/admin >> -I../libtd/ -I../liblogsvc -I../libti -Di386 \ >> -o disktest \ >> -L/export/slim_source/proto/root_i386/usr/snadm/lib \ >> -L../libti \ >> -L/lib \ >> objs/i386/*.o \ >> om_disk_test.o test_driver.o \ >> -ltd -lnvpair -lorchestrator -lict -ladmutil -ladmldb \ >> -llogsvc -lti -ltransfer -lbe -lelf >> >> -bash-3.2# make kbdtest >> /opt/SUNWspro/bin/cc -xc99=%none -Xa -I/usr/include -I/usr/include >> -I. -I/usr/include/admin -I../libtd/ -I../liblogsvc -I../libti >> -Di386 -I/usr/include -I/usr/include -I. -I/usr/include/admin >> -I../libtd/ -I../liblogsvc -I../libti -Di386 \ >> -o kbdtest \ >> -L/export/slim_source/proto/root_i386/usr/snadm/lib \ >> om_kbd_locale_test.o \ >> -ltd -lorchestrator -lict -lnvpair >> Undefined first referenced >> symbol in file >> set_user_name_password om_kbd_locale_test.o >> ld: fatal: Symbol referencing errors. No output written to kbdtest >> *** Error code 1 >> make: Fatal error: Command failed for target `kbdtest' >> >> And I didn't find implement of function set_user_name_password() in >> slim source directory: >> >> -bash-3.2# find /export/slim_source | xargs grep set_user_name_password >> /export/slim_source/usr/src/lib/liborchestrator/om_kbd_locale_test.c: >> >> set_user_name_password(optarg, optarg, NULL); >> /export/slim_source/usr/src/lib/liborchestrator/orchestrator_private.h:int >> set_user_name_password(char *user, char *login, char *passwd); >> >> Any suggestions for me? >> >> Thanks >> Li Fan > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
