Hi William,
William Schumann wrote:
> Honzo,
> It seems that to allow the installer to go to a slice other than slice
> 0, the only thing that needs to be done is to add another attribute to
> the ZFS root pool target: slice number.
> Would you concur?
I think that it is not needed to modify TI for this, since
existing TI_ATTR_ZFS_RPOOL_DEVICE is generic
enough - it allows you to create ZFS pool on any device,
not only slice - you can create pool on disk/partition/slice -
any device which 'zpool create' command accepts might
be used.
I think that it might be better to modify prepare_zfs_root_pool_attrs()
function to make it more generic - for instance, it might accept
'slice number' as additional input parameter.
Thank you,
Jan
> William
>
> Slice 0 is hard-coded below:
> static int
> prepare_zfs_root_pool_attrs(nvlist_t **attrs, char *disk_name)
> {
> ...
> snprintf(zfs_device, sizeof (zfs_device), "%ss0", disk_name);
>
> if (nvlist_add_string(*attrs, TI_ATTR_ZFS_RPOOL_DEVICE,
> zfs_device) != 0) {
> om_log_print("Could not set zfs rpool device name\n");
> ...
