Karen Tung wrote: > Jean McCormack wrote: >> Karen Tung wrote: >>> Hi Jean, >>> >>> Thanks for doing the work. Here are my comments: >>> >>> bootroot_archive.py: >>> - line 65, 105, 115: can we do a os.walk() to get through the list >>> of files instead of doing the "find"? >> I'm going to say "not now" on this one. Find is used in several >> places throughout the code, even prior >> to this fix. I'm keeping it consistent and expediting the push. If >> we wish to change it later we can. The >> code didn't really end up much cleaner when I looked into it. >> >> Jean >> > Hi Jean, > > Can you file a bug to keep track of this? You can make the bug > general so when we revisit it, > we can look at all the cases in the DC code that does find and see > whether we can > improve the code. > > Thanks, > > --Karen Bug number 5802
- [caiman-discuss] DC Code review for sparc support Jean McCormack
- [caiman-discuss] DC Code review for sparc support Karen Tung
- [caiman-discuss] DC Code review for sparc support Jean McCormack
- [caiman-discuss] DC Code review for sparc support Jean McCormack
- [caiman-discuss] DC Code review for sparc supp... Karen Tung
- [caiman-discuss] DC Code review for sparc ... Jean McCormack
- [caiman-discuss] DC Code review for sparc support Jack Schwartz
- [caiman-discuss] DC Code review for sparc support Jean McCormack
- [caiman-discuss] DC Code review for sparc supp... Jack Schwartz
- [caiman-discuss] DC Code review for sparc support Dave Miner
- [caiman-discuss] DC Code review for sparc support Jean McCormack
- [caiman-discuss] DC Code review for sparc supp... Dave Miner
- [caiman-discuss] DC Code review for sparc ... Jean McCormack
- [caiman-discuss] DC Code review for sparc supp... Karen Tung
- [caiman-discuss] DC Code review for sparc ... Jean McCormack
- [caiman-discuss] DC Code review for s... Jean McCormack
