Hi Jan, thank you very much for incorporating those changes !
Jan Jan Trejbal wrote: > Hello Jan, > good to hear you like the idea. > Thank you very much for very valid comments. I updated the proposal > document accordingly. See more details in-line. > > Jan Damborsky wrote: >> Hi Jan, >> >> thank you very much for coming with this proposal. >> In the past the installer was suffering from the lack of >> the API for dealing with languages and locale stuff. >> The implementation of G11N related stuff in the installer >> technologies was not robust and it was difficult to >> keep it up to date, since we were not aware of changes >> happening in that area. >> >> I think that having stable G11N API defined which install >> technologies might take advantage of would help to address >> most the of problems we have been encountering in that area. >> >> The high level proposal looks good, I have couple of comments. >> >> Since the module is planned to be implemented as C library, >> I would recommend to include also test driver as part of >> delivery. It could be used by QE team as part of their test >> suites for G11N module, it would make process of evaluating >> potential problems easier and could be used by other than >> C consumers as API wrapper (for instance in set_lang script). >> Please see Target Discovery or Target Instantiation test >> drivers for more details and possible implementation: >> >> http://src.opensolaris.org/source/xref/caiman/slim_source/usr/src/lib/libtd/test_td.c >> >> >> http://src.opensolaris.org/source/xref/caiman/slim_source/usr/src/lib/libti/test_ti.c >> > > > Command-line test driver is a good idea. I included it in proposal doc > and drawing. > Thank you for test driver examples. > >> >> >> Introduction of G11n install module >> ----------------------------------- >> The module would also provide way to >> set language and locale > > I changed Introduction and included the "set language/locale" > functionality in list of requirements. > >> >> Relation to other modules >> ------------------------- >> * picture >> In current implementation, set_lang is shell script, >> so it would probably take advantage of test driver >> instead of orchestrator for setting desktop language on livecd. >> also, the implementation is likely to be changed in the future, >> when support for graphical boot is available. > > Right, currently set_lang need to call the test driver. > In future this may change. > >> >> Thanks ! >> Jan >> >> >> >> Jan Trejbal wrote: >>> Hello Caiman team. >>> I would like to propose a new module which provides information >>> about languages and locales. >>> It's actually not a brand new module. My plan is to take >>> orchestrator locale.c component, remove unused code, add some new >>> functionality, and separate it out into a new stand-alone shared >>> library. >>> >>> I believe various installer appls (e.g. gui-install, AI) as well as >>> other system appls (e.g. post-install mngmt of language bits) would >>> benefit from proposed library. >>> >>> See more details at following document: >>> http://wikis.sun.com/download/attachments/45908778/g11ninstall_mod_proposal.pdf >>> >>> >>> >>> Can you please consider my proposal and review it? >>> Thank you, >>> Jan >>> >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>
