Susan Sohn wrote: > Hi Joe, > > On 12/23/09 13:35, Keith Mitchell wrote: >> Hi Joe, >> >> Thank you for taking the time to review. My comments are below. >> Incidentally, you've brought up some very good points that have made >> me go "hrmmmm," so I'd say it's a worthwhile review! >> >> - Keith >> >> Joseph J VLcek wrote: >>> >>> Hey Keith, >>> >>> Here is my feedback. Many of my comments are nit/questions. My Python >>> experience is limited still. So many of my comments my be due to >>> naivety. >>> >>> I may have learned more from doing this review than I provide. >>> >>> Hope this help. >>> Joe >>> >>> --- >>> > > >>> cmd/text-install/osol_install/text_install/help_screen.py >>> ------------------------------------------------------------------------------- >>> > > > <snip> > >>> Comment: >>> -------- >>> 202 help_text = self.get_help_topic(info[0]) >>> ... >>> 207 help_topic = info[0] >>> >>> I see an inconsistency: >>> >>> help_text is set using get_help_topic yet help_topic is not. Is this >>> wrong >>> or is the named backwards? >> >> I'll have to defer to Sue on this one. > > The choice of names could definitely be better here. > Will change 202 help_text to help_topic and 207 help_topic to > help_screens (the screens to which the help topic applies). > > Thanks, > Sue > > >
Great! Thanks Sue
