Hi Keith,
I am wondering if we still need to modify nightly
(step 3 in "To setup the repository to be built:").
I use stock /opt/onbld/bin/nightly to build my workspaces
and don't see warnings mentioned in bug 849:
dambi at tio:~/ws/os-install-bug-13238/usr/src$ grep getopts
/opt/onbld/bin/nightly
while getopts O FLAG $*; do
while getopts inS:tV: FLAG
while getopts 0AaBCDdFfGIilMmNnOoPpRrS:TtUuWwXxz FLAG $NIGHTLY_OPTIONS
dambi at tio:~/ws/os-install-bug-13238/usr/src$ grep NIGHTLY_OPTIONS=
developer.sh
export NIGHTLY_OPTIONS="-ANdlpn +t";
dambi at tio:~/ws/os-install-bug-13238/usr/src$ grep -i warning *.out
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115154421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115144421"
install-nd-i386.out:WARNING: parameter <PSTAMP> set to "tio20100115144421"
Other than that, LGTM
Thank you,
Jan
On 01/16/10 02:37 AM, Keith Mitchell wrote:
> Hi all,
>
> Can I get a code review for the following bugs:
>
> 13708 README file doesn't mention installing SUNWinstallint
> http://defect.opensolaris.org/bz/show_bug.cgi?id=13708
>
> 12336 update slim_source README to install SUNWzoneint from IPS
> instead of SVR4
> http://defect.opensolaris.org/bz/show_bug.cgi?id=12336
>
> 12385 Need to update getopts line in gate README
> http://defect.opensolaris.org/bz/show_bug.cgi?id=12385
>
> 11378 Fix readme to work around nightly bug for dmake
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1378
>
> The webrev is at:
> http://cr.opensolaris.org/~kemitche/13708/
>
> I welcome any recommendations for wording changes, or any other needed
> README changes. I've confirmed that the README is correct when
> following the given steps after a clean gui-install.
>
> - Keith
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
