Thanks for the review John, Apologies in the delay in getting back, as I am just back in the office today.
Barbara, can you respond to John's queries here ? John Fischer wrote: > Matt, > > Keep up the good work. A couple comments below. > > INSTALL_DISK_PANEL.txt: > > Did you intend to add a bunch of <CR>s at the end of the file? I'm not seeing this bunch of <CR>'s that you talk about.... can you elaborate further ? > > INSTALL_LANGUAGE_PANEL.txt: > > "...by using the Options button in the dialog box." > > I think that you need to be more specific here. It almost > sounds like you can go back to the installer and change the > locale there for the running system. So perhaps saying > something about login or GDM or ... > > INSTALL_TIMEZONE_PANEL.txt: > > "the dropdown selections automatically populate with the time zone..." > > You might change "populate" to "update". > > WELCOME_PANEL.txt: > 'To view the online help for this installer, select the "?" button > on an installer panel.' > > It seems kind of silly to explain how to get online help from > within the online help. Or is this the text that is show on > the Welcome panel itself? > > Appears to also have an extra <CR> at the end of the file. > > Thanks, > > John > > Matt Keenan wrote: >> Sort of Code review for Bug : >> 13559 - Integrate New Help Files for 2010.03 Release >> http://defect.opensolaris.org/bz/show_bug.cgi?id=13559 >> >> Webrev : >> http://cr.opensolaris.org/~mattman/bug_13559/ >> >> >> Updated help docs for GUI installer containing edits pertinent to >> 2010.03 release. No actual code just txt file updates. >> >> cheers >> >> Matt >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
