Hi Alok, transfer_mod.py: I'm wondering why you chose to use a "break" statement instead of updating either line 934 or line 941 such that they're both either using "retry_timeout > 0" (or both using ">= 0").
Additionally, if, after the timeout gets to 0 we haven't successfully executed this block, I think we'll want to explicitly raise a TAbort with a reasonable message. media-fs-root: It seems like we could leave the "sshd -c" and "svcadm enable" as common code, and then simply check the variable again and perform the set_lang/kbd commands in the liveCD case. (I just noticed that sshd -c is not run for liveCD - I didn't realize you could ssh in without running this command? Or does some magic happen elsewhere that makes it work?) The other files look good to my eye, but I'm not as familiar with that code, so take that statement with a grain of salt. - Keith Alok Aggarwal wrote: > Could I please get a couple of people to take a look at the code > changes for the following bugs? > > 13537 transfer module keeps trying to contact an unreachable IPS server > indefinitely > 13766 AI debug mode can only be activated in conjunction with service > discovery > 13795 Debug mode cannot be enabled in build 130 > 13979 fix for 12659 results in auto-installer not retrying when unable > to reach > the IPS repo > 13892 Selecting LiveCD Grub option "Enable SSH" should not prompt for > language > > Webrev location: > > http://cr.opensolaris.org/~aalok/13537-13766-13795-13979-13892/ > > Thanks, > Alok > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
