Hi Alok,

please see my comments below.

Thank you,
Jan


auto_installer
--------------

89 AI_DEBUG_MODE=`$GREP "^install_debug" \


'GREP' is not defined in the script, so I assume it
would not work (for Sparc).


media-fs-root
-------------
196 livessh=`$PRTCONF -v|$SED -n '/livessh/{;n;p;}'|$CUT -f 2 -d\'`

Just curious (I haven't tried), does it work for Sparc bootable AI
as well ?


transfer_mod.py
---------------

Why only '1' (not other error codes) returned
from pkg image-create triggers retry ?


It seems that is the case where C 'for' loop
would take care of this in elegant way - e.g.

for (status = 1; status == 1&&  retry_timeout>= 0; retry_timeout -= 10)
...

Then we could inspect 'status' once the loop finishes.

Not sure about how to accomplish this in elegant way
in Python.


On 01/20/10 12:01 AM, Alok Aggarwal wrote:
> Could I please get a couple of people to take a look at the code 
> changes for the following bugs?
>
> 13537 transfer module keeps trying to contact an unreachable IPS server
> indefinitely
> 13766 AI debug mode can only be activated in conjunction with service 
> discovery
> 13795 Debug mode cannot be enabled in build 130
> 13979 fix for 12659 results in auto-installer not retrying when unable 
> to reach
> the IPS repo
> 13892 Selecting LiveCD Grub option "Enable SSH" should not prompt for 
> language
>
> Webrev location:
>
> http://cr.opensolaris.org/~aalok/13537-13766-13795-13979-13892/
>
> Thanks,
> Alok
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


Reply via email to