John, thank you for reviewing those changes.
Jan On 01/20/10 04:41 PM, John Fischer wrote: > Jan, > > Looks good. > > John > > On 01/20/10 12:08 AM, Jan Damborsky wrote: >> Hi John, >> >> >> On 01/19/10 04:41 PM, John Fischer wrote: >>> Jan, >>> >>> Any particular reason why in grub_setup.py you are using: >>> >>>> + IMG_INFO_PATH = PKG_IMG_PATH + "/" + IMAGE_INFO_FILE >>> >>> instead of os.path.join(PKG_IMG_PATH, IMAGE_INFO_FILE)? >> >> I was inspired by existing implementation, but os.path.join() is >> definitely better :-) >> I have retested and updated the webrev accordingly: >> >> http://cr.opensolaris.org/~dambi/bug-13393/ >> >> Thank you very much for review, >> Jan >>
