On 01/21/10 11:24 AM, Darren Kenny wrote:
> In general looks fine, just 2 questions:
>
> 1) Why are the file modes changing from 644 to 755?

Fixed, I just untarred directly from tarball and these versions contained these 
permissions.

> 2) The new text isn't wrapped in some cases, giving long lines, does this
>     look acceptable when viewed, or does it need to be wrapped manually?

Lines should not be wrapped in the text files they should remain as long lines 
as they are automatically wrapped by GTK when viewed.

Updated Webrev available.

cheers

Matt

>
> Thanks,
>
> Darren.
>
> On 01/21/10 11:05 AM, Matt Keenan wrote:
>> Review of this help text has already been done, sending code review email to
>> have official record of approval to integrate.
>>
>>      Bug 13559 -  Integrate New Help Files for 2010.03 Release
>>      http://defect.opensolaris.org/bz/show_bug.cgi?id=13559
>>
>> Webrev :
>>      http://cr.opensolaris.org/~mattman/bug_13559/
>>
>> Need two approvals to integrate at this stage in development cycle.
>>
>> cheers
>>
>> Matt
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


Reply via email to