Hi Evan - I took a look. It looks ok to me.
ginnie On 01/23/10 22:29, Evan Layton wrote: > Requesting a Code review for bug 5711: > 5711 - libbe autonaming for zones datasets should use the same > method as the BE autonaming > http://defect.opensolaris.org/bz/show_bug.cgi?id=5711 > > Webrev: > http://cr.opensolaris.org/~evanl/5711/ > > This fix changes the way the auto-naming for zone BE's works so that > it matches that of the auto-naming for BE's. This eliminates possible > name collisions due to multiple processes as well as keeping the > auto-naming from reusing a name that may sill have a snapshot around > from before bug 10990 was fixed. > > The main name collision portion of the bug was fixed with bug 10990. > > Testing: > Ran stc libbe test suite - no unexpected test failures (any failures > were due to known ZFS unmount failure, > bugster bug 6872581) > Built build 131 iso and tested an install - all worked as expected. > > > Thanks, > > -evan > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss -- Ginnie
