Matt,

Looks good.

John


Matt Keenan wrote:
> 
> Request a few pairs of eyes for review of fix for :
>    12364 -  Doing livecd install had complains about <GUI:Gtk_E Oct 28 
> 23:13:41> file gtkprogress.c: line 540: assertion `percentage >= 0 && 
> percentage <= 1.0' failed
>    http://defect.opensolaris.org/bz/show_bug.cgi?id=12364
> 
> 
> Webrev :
>    http://cr.opensolaris.org/~mattman/bug-12364
> 
> 
> Fairly trivial fix to ensure when install screen GtkProgessBar is being 
> first
> initialized it is being set to a value within the correct range.
> 
> The warning is only being seen since gnome was upgraded to 2.28, as new 
> version of GTK is now outputting more warnings for correctness.
> 
> Non stopper bug, just want code review complete, in order to push when 
> slim_source gate splits.
> 
> cheers
> 
> Matt
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to