Thanks for the review John, Update webrev to contain CDDL updates aswell. Matt
On 01/27/10 05:09 PM, John Fischer wrote: > Matt, > > Please update the copyright date for the CDDL headers. Once > this is done the changes look good. > > Thanks, > > John > > Matt Keenan wrote: >> Code review request for bug : >> 12167 - GUI Installer Window Bar Icon Shows Up as Square Red X >> http://defect.opensolaris.org/bz/show_bug.cgi?id=12167 >> >> Webrev : >> http://cr.opensolaris.org/~mattman/bug-12167 >> >> Simple enough change to ensure default window icon for gui-install is >> set to >> correct system default of system-software-install. >> >> Also change user jack's home environment to not deliver a custom icon, >> as this >> icon should really be delivered by SUNWgnome-themes in nimbus theme, >> which it will via bug 14167. >> >> Bug is not a stopper and will only get pushed when slim_source gate >> has been split for 2010.03, just wanted to get code review completed >> so I could just push when the time comes. >> >> Tested on a DC built 131 ISO. >> >> cheers >> >> Matt >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
