Evan, Just some more nits below, otherwise looks okay.
be_list.c --------- 392 - you were right, this should be 'container' not 'parent' 771 - nit - need an empty line after this line 872,873 - redundant assignment 965 - This variable isn't needed anymore; just assign snapshot->be_snapshot_space_used at 1010 thanks, -ethan Evan Layton wrote: > Hi Ethan, > > As per our IRC chat and phone conversations I've moved the call to > zfs_iter_snapshots so that it's only called if be_name is set and > I've updated the calls to both be_get_ss_data() (around lines 409 > to 434) and be_get_ds_data() (around lines 453 to 485) so they are > only called once in be_add_children_callback instead of twice like > I had before. > > I've updated the webrev to reflect these changes as well as the rest > of the previous comments. > > Thanks! > -evan > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
