jan damborsky wrote: > Hi Dave, > > thank you very much for your comments. > Please see my response in line. > > Jan > > > Dave Miner wrote: >> jan damborsky wrote: >>> Hi, >>> >>> could I please ask for reviewing the easy fix for following bug ? >>> >>> 4336 AI image should have link to /usr/has/bin/vi >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4336 >>> >>> webrev is available at: >>> http://cr.opensolaris.org/~dambi/bug-4336 >>> >> Something seems wrong to me here. The AI image manifest includes >> /usr/bin/vi and /usr/has/bin/vi in the bootroot_contents list, and yet >> we have this code in ai_bootroot_configure doing seemingly similar >> things. > > Thank you for catching this. /usr/bin/vi should have been removed > from bootroot_contents list, since it doesn't exist in AI image. > I have removed it from AI DC manifests nad updated webrev accordingly. > > /usr/bin/vi used to be delivered by SUNWcs package (as hardlink > to /usr/bin/edit), but at one moment (not sure which build) > /usr/bin/vi was moved to /usr/has/bin/vi and SUNWvim package started > to create /usr/bin/vi as symbolic link to /usr/bin/vim. > > SUNWvim is not pulled into AI image, since it has ~17MB and vi seems > to cover sufficiently needs in AI environment as far as editing > capabilities are concerned. > >> I'm not at all following why this doesn't work after /usr is >> mounted from the image, either; is it just a matter that /usr/bin/vi >> isn't in the package area before we start archiving into the root >> archive? > > Yes, this is correct - please see my comment above. > >> If so, then that seems like the better fix. > > If I understand correctly, you recommend to create /usr/bin/vi > link in AI proto area instead of /sbin/vi link in boot archive ? >
Yes, then you could just leave /usr/bin/vi in the root archive contents and it would all be right. Dave
