Hi Jan.
Thanks for changing the message.
I noticed one other nit now. On 330, the comment is "Lofi mount ... to
/usr and /mnt/misc...
Both of us know that the mount of /tmp/solaris.zlib on /usr is a
behind-the-scenes lofi mount, but someone else might get confused by 330
as lofiadm isn't explicit for /usr.
Do you think it would help to add a comment before 344 saying a lofi
mount is done implicitly because /tmp/solaris.zlib is a file? I leave
it up to you. No need for me to see a new webrev if you add this comment.
thanks,
Jack
On 02/05/09 08:32, jan damborsky wrote:
> Hi Jack,
>
>
> Jack Schwartz wrote:
>> Hi Jan.
>>
>> Fix looks good and nice bug analysis too.
>
> Thank you :-)
>
>> The only thing I would change is to somehow distinguish the message
>> on 340 from the one on 347 for easier debugging. Maybe change 340
>> to "Couldn't lofi mount /usr/filesystem"?
>
> I agree - the messages should be different.
> I have changed the first one according to
> your suggestion. Could I please ask you
> to take a look at updated webrev ?
>
> Thanks again,
> Jan
>
>
>>
>> Thanks,
>> Jack
>>
>> On 02/05/09 04:09, jan damborsky wrote:
>>> Hi,
>>>
>>> could I please ask for reviewing the easy fix for following bug ?
>>>
>>> 5588 Can't su to root from jack when observing automated
>>> installation on client side
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=5588
>>>
>>> webrev is available at:
>>> http://cr.opensolaris.org/~dambi/bug-5588
>>>
>>> Thank you,
>>> Jan
>>>
>>> Modules affected:
>>> -----------------
>>> * live-fs-root
>>>
>>> Testing done:
>>> -------------
>>> * live-fs-root replaced in boot archive
>>>
>>> * verified that su works in AI environment:
>>>
>>> jack at opensolaris:~$ su -
>>> Password: Sun Microsystems Inc. SunOS 5.11 snv_106 November 2008
>>> root at opensolaris:~#
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>>
>
