William Schumann wrote: > Currently in the AI manifest, if zero is specified as a requested size > for partitions or slices, the maximum available space will be > allocated. This is non-intuitive, and for clarity, a keyword "max_size" > shall be used for RNG elements "slice_size" or "partition_size". > > http://cr.opensolaris.org/~wmsch/bug-5653/ > http://defect.opensolaris.org/bz/show_bug.cgi?id=5653 > > The sizes in the RNG file had to be changed from numeric only to text. > > Other changes include: > - additional manifest parsing problems logged and manifest parsing > failure path added > - removing unnecessary functions to fetch particular manifest elements > replacing it with a generic routine (auto_parse.c) > - logging routine added to log and print message to file > - adding command line options for breakpoints for testing > - moved common code to disk_target.c from disk_parts.c and > disk_slices.c, fixing bug with missing disk sector size > > Unit testing for slice/partition for x86 + slice for SPARC: > - invalid values for size (alpha, out of range) > - varying existing partition layouts testing maximum size allocation > algorithm > - slice editing, partition editing, both > - testing breakpoint code > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
William, I realize this is not the norm but your changes for 5653 are substantial. Would you mind doing a code walk through with me? In the mean time I'll start looking at it. Joe
