On 02/20/09 11:14, Alok Aggarwal wrote:
>
> On Fri, 20 Feb 2009, Jens Deppe wrote:
>
>> Hi
>>
>> Should I expect that a manifest without any packages defined, when
>> used in an install, would result in the base set of packages being
>> installed (SUNWcsd, SUNWcs, slime_install and entire)?
>
> Yes.
>
>> If so, then I think create_package_list() is buggy and the check for
>> the number of packages in the manifest should result in the default
>> list being used in the event that none are indeed defined.
>
> I'm not following, could you please expand on that?
Here's the call chain as I see it:
auto_perform_install() -> install_from_manifest() ->
create_package_list_file(B_FALSE)
In create_package_list_file(), the 'if (hardcode)' block is skipped and
then the code below results in no packages being defined in the package
list file:
package_list = ai_get_manifest_packages(&num_packages);
if (num_packages <= 0)
goto errorout;
I would think that instead of bailing at this point the default list of
packages should be defined for installation. No?
--Jens
