Looks good to me. cheers
Matt On 02/ 8/10 03:13 PM, Darren Kenny wrote: > Hi, > > > I would appreciate if I could get some review of this change for defect 13993: > > http://cr.opensolaris.org/~dkenny/fix.13993.slim/ > > where the GUI was changing the partition id of an unmodified primary partition > when it should have be remained in the same location. > > For example, if you had the following layout: > > Partition Partition > Id Type > > 1 Win95 > 2 FAT32 > 3 Linux > 4 Extended > > and you removed partition id 2, with this fix you will get: > > Partition Partition > Id Type > > 1 Win95 > 2 UNUSED > 3 Linux > 4 Extended > > Where previously, without this fix, you would have got: > > Partition Partition > Id Type > > 1 Win95 > 2 Linux <-Error! > 3 Extended <-Error! > 4 UNUSED <-Error! > > This would result in the Linux partition being unbootable (with out some > detailed knowledge of the boot process) since it's root disk would have gone > from /dev/hda3 to /dev/hda2, meaning that GRUB couldn't then find it, and if > you > managed to get past then, then the vfstab file would be wrong. > > This is /possibly/ one of main reason that people install OpenSolaris after > installing everything else in a multiboot environment (the other being that > you > need to use the OpenSolaris GRUB to read ZFS). > > NOTE: Logical partitions will still have their partition id's changed but that > is how it behaves in practice, even if you do it on other OSes like Linux and > Windows. > > Thanks, > > Darren. > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
