Ethan, I have posted a "delta" webrev which includes the needed change you've identified. I also removed some no longer used variable and fixed a bug I found during testing - requiring "\" in front of "$ISADIR".
The delta webrev can be viewed here: http://cr.opensolaris.org/~joev/bug14267_slim_source_rd2/ Thanks, Joe On 02/ 8/10 04:28 PM, Ethan Quach wrote: > Joe, > > Just one small comment at 291, min_mem64 should probably be > grabbed from the existing media's grub menu if it exists. > > Otherwise looks okay. > > > thanks, > -ethan > > > On 02/07/10 15:23, Joseph J. VLcek wrote: >> On 02/ 5/10 03:20 PM, Joseph J. VLcek wrote: >>> Please review: >>> >>> http://cr.opensolaris.org/~joev/bug14267 >>> >>> which addresses >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14267 >>> >>> >>> Testing done: >>> >>> - Ran the updated script against the latest 132 AI ISO >>> - Booted the ISO generated by the script >>> - Observed the correct behavior of: >>> 1. The GRUB menu was correct >>> 2. AI shutdown the system once the install completed. >>> >>> >>> Thanks, Joe >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> Ethan or Glenn. or anyone else. could you please take a look and tell me >> how wonderful these changes look? ;) >> >> >> >> Basically what I am doing is, instead of editing the existing GRUB menu, >> I am creating the GRUB menu as needed by VMC. >> >> Joe
