Keith, Looks good.
- Dermot On 02/11/10 23:14, Keith Mitchell wrote: > A pair of glaring omissions on my part. > > Here's a webrev containing the missing changes: > http://cr.opensolaris.org/~kemitche/text_v4a/ > > - Keith > > On 02/11/10 03:03 PM, Dave Miner wrote: >> On 02/11/10 05:56 PM, Keith Mitchell wrote: >>> Hi all, >>> >>> Thank you for taking the time to review the text installer code. >>> Feedback from this round of code review has been incorporated. An >>> incremental webrev is available at: >>> http://cr.opensolaris.org/~kemitche/text_v4_incremental/ >>> >>> Please take a moment to ensure your comments have been adequately >>> addressed. >>> >> >> Not quite. >> >> install-finish appears to be missing, should have been a change based >> on this: >> >>>> install-finish, 129: Why is it necessary to restrict this particular >>>> > function to only the textinstall case? Granted, you're the only user >>>> > of it right now, but it seems excessively restrictive. >>> I spoke with Karen and there's no particular reason for this >>> restriction, so I'll remove it. >>> >> >> The comment at line 49 in text-mode-menu.ksh is still incorrect >> (referring to LC_ALL rather than LANG). >> >> Dave
